DefMod Syntax
Jonathan Coxhead
jonathan at doves.demon.co.uk
Thu Mar 16 02:15:56 GMT 2000
| > I made everything FullMessage. Maybe that was a poor choice;
| >how about Msg? I'm open to suggestions; It's easy enough to change
|
| The lack of response is overwhelming ;-)
| Does this mean that there are no better suggestions?
There were 2 votes to leave it out altogether, I think. I don't
see that the need to vary the system for Wimp_WindowInfo and
WimpSlotSize is big argument against. Wimp_WindowInfoChanged (if
that's what it means---I have no idea!) and Wimp_NewSlotSize aren't
bad names, e g.
I wouldn't have mentioned it, except you brought it up. Whoever
does the work, makes the decision. That's my view.
| There is another change I made to your proposed header: I renamed
| "size" to "messagesize", and "sender" to "messagesender" to avoid
| clashes with "size" in (say) wimp_ram_xfer, and "sender" in
| "alarm_set". I was tempted to rename "action" to "messageaction",
| although presently no clash exists. "my_ref" and "your_ref" should
be
| safe enough. What do you think?
I think it's either an inconsistency between what should be the
same names in 2 different structures (Wimp_Message, Wimp_Message-
Header), or else it breaks compatibility. It also seems odd to change
the name in the header, when that is the logically prior structure.
Why not "xfer_size", "sender_name", etc? (But only in the
Wimp_RamXfer, Alarm_Set structures, of course, whatever you call
them. Wimp_MessageRAMXfer, Alarm_MessageSet have to stay as-is.) So
we get the inconsistency of names, which is a shame, but resolved it
in the opposite direction.
The logic is this: the Wimp_MessageHeader names are used all the
time by everyone who uses Wimp messages, so should remain consistent
with existing practice. The names in the RAMXfer structure are only
used by people using RAM transfer messages, and there must logically
be fewer (<=) of them. So they get to pay the higher price of
learning a few new names. Ditto for Alarm_Set, etc etc.
| On the subject of name clashes, Tom, you will need to do something
| similar for your gadget object structure: "flags" is duplicated in
| many objects - I've called it "gadgetflags".
Again, I think the opposite resolution should be used. The base
structure is fully entitled to use short names: it's up to the
clients who extend the base structure by inheritance to avoid the
names in the base.They can always do this.
But, whatever you want :-)
/|
o o o (_|/
/|
(_/
More information about the oslib-team
mailing list