Bug in "*_no_fail" functions

[Tony van der Hoff]

On 20 Dec 2001, in message <a09b3ec4a%Marco at dionin.esw-heim.tu-clausthal.de>,
Marco Baye <Marco.Baye at tu-clausthal.de> wrote:

> Hi!
> 
> I just found a bug in the OS Lib functions
>   os_change_dynamic_area_no_fail(),
>   xos_change_dynamic_area_no_fail(),
>   osheap_resize_no_fail() and
>   xosheap_resize_no_fail().
> 
[snip]
> 
> In both cases, the CMP instruction compares the fixed error number
> to the returned *error block pointer* instead of to the error
> number in the returned error block.

Oh, B...

You're quite right, a mental aberration on my part; and I should have tested
it better :-( Apologies to one and all.

> So there's just a "LDR R0, [R0]" instruction missing in each case.
> 
No, that would destroy the error return for anything other than the case
we're testing for. However, I take your point.

> I dowloaded and installed the latest release of OS Lib a few days
> ago, and I subscribed to this list just half an hour ago. So please
> forgive me if this topic has already been discussed at length
> before.

Not at all. Welcome to OSLib, and thanks very much for taking the trouble
to report this bug. I'll fix it, and try to get a new release out today.

-- 
Tony van der Hoff         | MailTo:tony at mk-net.demon.co.uk
                          | MailTo:avanderhoff at iee.org
Buckinghamshire, England  | http:www.mk-net.demon.co.uk