OSLib bug fixes (various)

Timothy Baldwin csyteb at comp.leeds.ac.uk
Mon Jan 15 22:51:58 GMT 2001


On Mon, 15 Jan 2001, Tony van der Hoff wrote:
> On Sun, 14 Jan 2001, at 18:43:29, Timothy Baldwin
> <csyteb at comp.leeds.ac.uk> wrote on the subject "OSLib bug fixes
> (various)":
> 
> >On Fri, 12 Jan 2001, Daniel Ellis wrote:
> >> On Fri 12 Jan, Tony van der Hoff wrote:
> >
> >> > >+ os_int_on() and os_int_off() added as these can be called from user
> >> > >   and 32 bit modes.
> >> > Really? With valid APCS - this was the reason they weren't included in
> >> > the first place.

[snip]
 
> I certainly have no objection to enabling these modes, if that's what
> people want...

Don't count me in, I only spotted there absence.

> >> > >+ DefMod checks SWI numbers with |xos_swi_number_from_string|.
> >> 
> >> Surely this will error if the module supplying the SWI isn't resident?
> >
> >In which case the SWI number is assumed to be valid.
> >
> I think this is quite a good idea, but it should throw a warning, not an
> error. I haven't looked that closely at the patch, Timothy, what does it
> actually do?

It reports an error including the SWI name, the number in the swi file and the
number returned by xos_swi_number_from_string() , as I considered this to be a
reliable indication that the swi file is incorrect. However on second thoughts,
there are situations where this could be incorrect.

-- 
Timothy Baldwin




More information about the oslib-user mailing list