Couple of bugs

John Tytgat John.Tytgat at aaug.net
Fri Sep 21 10:35:36 BST 2007


In message <dc92b6224f.christian at venice.lab>
          Christian Ludlam <christian at recoil.org> wrote:

> Here's a couple of trivial things:
> 
> * territory_ALPHABET_UTF8 isn't defined (it's 111)

I've added this.

> * draganobject_function is an anonymous structure, which means Norcroft
>   generates "cast between function and non-function" warnings. Does DefMod
>   not provide a "function" fundamental type?

It does.  The "function" type is also used in the PCI swi interface file
but it is not clear to me if this is the same APCS interface as for
DragAnAobject swi.

> It should be fairly easy to add.

If the PCI swi function is also an APCS function, I think it is nice
suggestion to change this in defmod2.  Does someone feel contributing such
a change ?

> * inetsuite_full_message_open_url_indirect is missing its
>   wimp_MESSAGE_HEADER_MEMBERS at the start - instead of this
> 
>      InetSuite_FullMessageOpenURLIndirect =
>         .Struct
>         (  .Int: tag,
> 
>   it should be
> 
>      InetSuite_FullMessageOpenURLIndirect =
>         .Struct: Wimp_MessageHeader
>         (  .Int: tag,

Indeed, I added this change to the simplified-build branch as well.
<URL:http://ro-oslib.svn.sourceforge.net/viewvc/ro-oslib?view=rev&revision=285>
for your reference.

Speaking of the simplified-build branch changes, I've finished that work
several months ago and also added GCCSDK 4 ELF support as well.  I intend
to merge to trunk the day I've done testing the ELF bits on RISC OS.  Not
sure when exactly this will happen but I have GCC 4.1 running on RISC OS
since some time.

Thanks Christian,
John.
-- 
John Tytgat, in his comfy chair at home                                 BASS
John.Tytgat at aaug.net                             ARM powered, RISC OS driven



More information about the oslib-user mailing list